帮我看一下有什么问题没有

[shankaipingo]

SET QUOTED_IDENTIFIER ON 
GO
SET ANSI_NULLS ON 
GO





ALTER       Proc [AddAGroup]
@Title		NvarChar(50), 
@AllowNoneApproval	tinyInt, 
@DomainName	NvarChar(50), 
@Description	NvarChar(500), 
@BgImage	NvarChar(200), 
@GroupRules	NvarChar(500), 
@SubTitle	NvarChar(50), 
@Logo		NvarChar(200),
@creator	NvarChar(50),
@creatorid	Int,
@groupid	Int	Output
As 




begin transaction
	INSERT INTO [Group] 
		 ( 
		 [Title],
		 [allowNoneApproval],
		 [DomainName],
		 [Description],
		 [bgImage],
		 [MemberCount],
		 [TopicCount],
		 [Hits],
		 [GroupRules],
		 [subTitle],
		 [Logo],
		createDate
		 ) 
	 
	VALUES 
		( 
		 @Title,
		 @allowNoneApproval,
		 @DomainName,
		 @Description,
		 @bgImage,
		 1,
		 0,
		 0,
		 @GroupRules,
		 @subTitle,
		 @Logo,
		getdate()
		 )
if(@@error<>0)
	begin
		rollback transaction
		return -1
	end

Set @groupid=@@IDENTITY

INSERT INTO [GroupMember] 
		(
		[UserId],
		[GroupId],
		[GroupMemberType],
		[username]
		)
VALUES 
		(
		@creatorid,
		@groupid,
		1,
		@creator
		)


if(@@error<>0)
	begin
		rollback transaction
		return -1
	end

commit transaction
return @groupid


GO
SET QUOTED_IDENTIFIER OFF 
GO
SET ANSI_NULLS ON 
GO

[Limpire]

ALTER       Proc [AddAGroup]
@Title        NvarChar(50), 
@AllowNoneApproval    tinyInt, 
@DomainName    NvarChar(50), 
@Description    NvarChar(500), 
@BgImage    NvarChar(200), 
@GroupRules    NvarChar(500), 
@SubTitle    NvarChar(50), 
@Logo        NvarChar(200),
@creator    NvarChar(50),
@creatorid    Int,
@groupid    Int    Output
As 

SET XACT_ABORT ON

begin transaction
    INSERT INTO [Group] 
         ( 
         [Title],
         [allowNoneApproval],
         [DomainName],
         [Description],
         [bgImage],
         [MemberCount],
         [TopicCount],
         [Hits],
         [GroupRules],
         [subTitle],
         [Logo],
        createDate
         ) 
     
    VALUES 
        ( 
         @Title,
         @allowNoneApproval,
         @DomainName,
         @Description,
         @bgImage,
         1,
         0,
         0,
         @GroupRules,
         @subTitle,
         @Logo,
        getdate()
         )
/*
if(@@error<>0)
    begin
        rollback transaction
        return -1
    end
*/

Set @groupid=@@IDENTITY

INSERT INTO [GroupMember] 
        (
        [UserId],
        [GroupId],
        [GroupMemberType],
        [username]
        )
VALUES 
        (
        @creatorid,
        @groupid,
        1,
        @creator
        )

/*
if(@@error<>0)
    begin
        rollback transaction
        return -1
    end
*/

commit transaction
--return @groupid

SET XACT_ABORT OFF

GO

[Limpire]

OUPUT参数不用RETURN。
RETURN是返回值，永远是整数。

[shankaipingo]

我的行不行？

[Limpire]

行

[shankaipingo]

谢就一个字！！

[shankaipingo]

这个会引出孤立事务吗？？？http://computer.stuun.cn/sanjikaoshi/shujuku/118572747137006_2.html，
看了这篇文章，我很害怕　

[Limpire]

你这种情况不会
当然用我的写法更好一些

[-狙击手-]

路过

[shankaipingo]

谢谢