这SQL Update语句没报错有什么更新不了

[xxingmen]

   protected void Button1_Click(object sender, EventArgs e)
    {
        string insert = "insert into my(title,Descriptionp,Keywords,Telephone,Email,createdata)values(@title,@Descriptionp,@Keywords,@Telephone,@email,@createdata)";
        string update = "UPDATE [My] SET [title] = @title, [Descriptionp] = @Descriptionp, [Keywords] = @Keywords,  [telephone] = @telephone, [email] = @email";
        string sel = "select * from [my]";
        string connstring = WebConfigurationManager.ConnectionStrings["qiluConnectionString"].ConnectionString;
        SqlConnection conn = new SqlConnection(connstring);
        conn.Open();
        SqlCommand cmd = new SqlCommand(sel, conn);
        try
        {
            cmd.Parameters.Add("@title", SqlDbType.VarChar).Value = title.Text.Trim();
            cmd.Parameters.Add("@Descriptionp", SqlDbType.VarChar).Value = Descriptionp.Text.Trim();
            cmd.Parameters.Add("@Keywords", SqlDbType.VarChar).Value = keywords.Text.Trim();
            cmd.Parameters.Add("@Telephone", SqlDbType.VarChar).Value = telephone.Text.Trim();
            cmd.Parameters.Add("@email", SqlDbType.VarChar).Value = email.Text.Trim();
            cmd.Parameters.Add("@createdata", SqlDbType.VarChar).Value = DateTime.Now;
            SqlDataReader rea = cmd.ExecuteReader();
            if (!rea.Read())
            {
                rea.Close();
                cmd.CommandText = insert;
                cmd.ExecuteNonQuery();
                Page.ClientScript.RegisterStartupScript(this.GetType(), "kk", "<script>alert('成功(*^ _ ^*)')</script>");
            }
            else
            {
                rea.Close();
                cmd.CommandText = update;
                cmd.ExecuteNonQuery();
                Page.ClientScript.RegisterStartupScript(this.GetType(), "kk", "<script>alert('更新成功')</script>");
            }
        }
        catch
        {
            Page.ClientScript.RegisterStartupScript(this.GetType(), "kk", "<script>alert('数据插入失败，请检查输入是否正确或申请技术支持')</script>");
        }
        finally
        {
            cmd.Dispose();
            conn.Close();
        }
    }

调试的时候没有提示出错， 就是更新不了

更新是用cmd.ExecuteNonQuery(); 没错吧

[哥本哈士奇]

hi,我发现你的update语句没有写where子句哦.
常理来说更新的时候,你确定记录存在了,应该把其id读取出来,然后加到where的后面.

[Fibona]

ExecuteNonQuery();没有错

[Fibona]

你的语句我测试了没有问题

[hdzdw]

string insert = "insert into my(title,Descriptionp,Keywords,Telephone,Email,createdata)values(@title,@Descriptionp,@Keywords,@Telephone,@email,@createdata)";

看是不是这里错了，注意空格！

[曾默]

这个判断改成别的方式试试
SqlDataReader rea = cmd.ExecuteReader();
if (!rea.Read())
{
用datatable的方式去判断下库里有没有数据

或许是根本没执行到else语句

[ufo20020427]

用SQL Server Profiler看下执行情况

[xxingmen]

where 写了，还是更新不了， 用控件了， 呵呵

[mltx]

是什么数据库，Oracle？可以把语句先在pl/sql中试一下就清楚了

[路人乙e]

cmd.Parameters.Add("@title", SqlDbType.VarChar).Value = title.Text.Trim();
cmd.Parameters.Add("@Descriptionp", SqlDbType.VarChar).Value = Descriptionp.Text.Trim();
cmd.Parameters.Add("@Keywords", SqlDbType.VarChar).Value = keywords.Text.Trim();
cmd.Parameters.Add("@Telephone", SqlDbType.VarChar).Value = telephone.Text.Trim();
cmd.Parameters.Add("@email", SqlDbType.VarChar).Value = email.Text.Trim();

SqlDataReader rea = cmd.ExecuteReader();
if (!rea.Read())
{
cmd.Parameters.Add("@createdata", SqlDbType.VarChar).Value = DateTime.Now;
rea.Close();
cmd.CommandText = insert;
cmd.ExecuteNonQuery();
Page.ClientScript.RegisterStartupScript(this.GetType(), "kk", "<script>alert('成功(*^ _ ^*)')</script>");
}

[yuziyuedemsdn]

JF

[编程有钱人了]

无条件的更新 是不是很危险啊