谁能帮忙看下我这个递归问题的一个小错误？

[tommyxdf]

#include <iostream>
#include <string>
using namespace std;

string lyric(int);
void printLyrics(int);
int main()
{
for (int i=1;i<=6;i++)
{
printLyrics(i);
}
return 0;
}

string lyric(int n)
{
string lyric;
if(n==1)
lyric ="B-I-N-G-O!";
else if(n==6)
{
string preLyric = lyric(n-1);
int position = preLyric.find(")");
lyric = preLyric.replace(position,4,",clap)");
}
else
{
string preLyric = lyric(n-1);
int position = preLyric.find(")");
lyric = preLyric.replace(position,3,",clap)");
}
return lyric;
}

void printLyrics(int n)
{
cout<<"There was a farmer had a dog,"<<endl;
cout<<" And Bingo was his name-o."<<endl;
cout<<" "<<lyric(n)<<endl;
cout<<" "<<lyric(n)<<endl;
cout<<" "<<lyric(n)<<endl;
cout<<"And Bingo was his name-o!"<<endl;
cout<<endl;
}

[lightnut]

string lyric(int n)
{
string lyric;
===========>
变量名字不要与函数名相同!
string lyric 中得lyric改其他名字!

[mengde007]

恩，1楼正解……

[tommyxdf]

改过来了 但编译的时候没问题 运行的时候就报错了。。。

[zbihong]

[Quote=引用 1 楼 lightnut 的回复:]
string lyric(int n)
{
string lyric;
===========>
变量名字不要与函数名相同!
string lyric 中得lyric改其他名字!
[/Quote]

UP!!!

[「已注销」]

问题出在preLyric.replace，你要先判断一下是否查找到了！

#include <iostream>
#include <string>
using namespace std;

string lyric(int);
void printLyrics(int);
int main()
{
    for (int i = 1; i <= 6; i++)
    {
        printLyrics(i);
    }
    return 0;
}

string lyricFunc(int n)
{
    string lyric;
    if (n == 1)
        lyric = "B-I-N-G-O!";
    else if (n == 6)
    {
        string preLyric = lyricFunc(n - 1);
        int position = preLyric.find(")");

        if (position != -1)
        {
            lyric = preLyric.replace(position, 4, ",clap)");
        }
    }
    else
    {
        string preLyric = lyricFunc(n - 1);
        int position = preLyric.find(")");

        if (position != -1)
        {
            lyric = preLyric.replace(position, 3, ",clap)");
        }
    }
    return lyric;
}

void printLyrics(int n)
{
    cout << "There was a farmer had a dog," << endl;
    cout << "    And Bingo was his name-o." << endl;
    cout << "        " << lyricFunc(n) << endl;
    cout << "        " << lyricFunc(n) << endl;
    cout << "        " << lyricFunc(n) << endl;
    cout << "And Bingo was his name-o!" << endl;
    cout << endl;
}

[tommyxdf]

变量名字改过来了，编译通过了。但是运行的时候报错，研究了一下应该是
myLyric = preLyric.replace(position,3,",clap)");
这句话的问题，但不知道问题在哪里？

[猫已经找不回了]

你先描述下你的代码功能

string lyric(int); 
void printLyrics(int); 

int main() 
{ 
	for (int i=1;i <=6;i++) 
	{ 
	printLyrics(i); 
	} 
	return 0; 
} 

string lyric(int n) 
{ 
	string ly; 
	if(n==1) 
	ly ="B-I-N-G-O!"; 
	else if(n==6) 
	{ 
		ly = lyric(n-1); 
		int position = ly.find(")"); 
		ly = ly.replace(position,4,",clap)"); 
	} 
	else 
	{ 
		string preLyric = lyric(n-1); 
		int position = ly.find(")"); 
		ly = ly.replace(position,3,",clap)"); 
	} 
	return ly; 
} 

void printLyrics(int n) 
{ 
	cout <<"There was a farmer had a dog," <<endl; 
	cout <<"    And Bingo was his name-o." <<endl; 
	cout <<"        " <<lyric(n) <<endl; 
	cout <<"        " <<lyric(n) <<endl; 
	cout <<"        " <<lyric(n) <<endl; 
	cout <<"And Bingo was his name-o!" <<endl; 
	cout <<endl; 
}

[tommyxdf]

结了，我太粗心了。谢谢各位！

[T技术沙龙]

[Quote=引用 5 楼 Loaden 的回复:]
问题出在preLyric.replace，你要先判断一下是否查找到了！


C/C++ code#include <iostream>
#include <string>
using namespace std;

string lyric(int);
void printLyrics(int);
int main()
{
for (int i = 1; i <= 6; i++)
{
printLyrics(i);
}
return 0;
}

string lyricFunc(int n)
{
string lyric;
if (n == 1)
lyric = "B-I-N-G-O!";
else if (n =…
[/Quote]
这个在我的vc++上可以运行，你是输出一首英文歌么？
可能是你的编译器出问题了吧