成员变量为指针数组的问题

[lee1800]

大家好 谢谢大家关注我的问题
请大家看下我下面这段程序是否有误..
PaintTable.h

class CPaintTable
{
public:
	CPaintTable(void);
public:
	~CPaintTable(void);
.........
private:
	int *m_Timeindex;
	ClrStruct *m_ClrItems;
};

PaintTable.c

CPaintTable::CPaintTable(void)
{
	m_Timei = 0;
	m_NewResulti = 0;
	m_LiveD.Rst =0;
	m_LiveD.Data.RemoveAll();
	m_LiveD.fn = 0;
}
/*---------------------------------------------------------------------------
* 函数名称：~CPaintTable(void);

* 函数功能：析构函数
----------------------------------------------------------------------------*/
CPaintTable::~CPaintTable(void)
{
	delete []m_Timeindex;
	delete []m_ClrItems;
}


void CPaintTable::GetAllMatchData(CWnd *pwnd,CStringArray &XMLI,int &ViewW,int &ViewH)
{
	int NewResultTemp = 0;
	m_XMLItems.Copy(XMLI);
	//m_GXML.GetMatchState(m_XMLItems,m_MatchState);
	m_GXML.DateNumber(m_XMLItems,m_DateItems);
	//按日期排位置
	m_GXML.CompositorFunction(m_XMLItems,0,m_XMLItems.GetSize()-1,TimeCompositor);
	m_GXML.DataProcessing(m_DateItems,m_XMLItems);//,m_MatchNow);
	long CountofItems = 0;
	CountofItems = m_XMLItems.GetSize();
        //重点在这。。
	m_Timeindex = new int [CountofItems];
	m_ClrItems = new ClrStruct [CountofItems];
	for( int i = 0; i < CountofItems; i++ )
	{
		if (m_XMLItems.GetAt(i) != _T("$$"))
		{
			m_ClrItems[i] = m_GXML.ParseXMLClr(m_XMLItems.GetAt(i));
		}
		if (m_XMLItems.GetAt(i) == _T("%%"))
		{
			NewResultTemp++;
		}
	}

	CClientDC dc (pwnd);
	m_nCellWidth = dc.GetDeviceCaps (LOGPIXELSX);
	m_nCellHeight = dc.GetDeviceCaps (LOGPIXELSY) / 4 - 10;
	ViewW = nViewWidth;
	ViewH = m_nCellHeight * ((CountofItems)*2 - m_DateItems.GetSize() - NewResultTemp );
}

[zkw0302]

一定要注意
构造函数中要赋初值
m_Timeindex = NULL;

析构函数中删除之前要判断
if(m_Timeindex != NULL)
{
delete []m_Timeindex;
m_Timeindex = NULL;

}

[oldn123]

如果GetAllMatchData被多次调用会有内存泄露.
构造函数中
m_ClrItems = NULL;
m_Timeindex= NULL;
改成

if(m_Timeindex)
{
     delete [] m_Timeindex;
}
m_Timeindex = new int [CountofItems];

if(m_ClrItems)
{
     delete [] m_ClrItems;
}
m_ClrItems = new ClrStruct [CountofItems];

[lee1800]

谢谢各位大大。。

[zkw0302]

为了访问不越界，最好加成员变量保存数组的大小

[lee1800]

[Quote=引用 4 楼 zkw0302 的回复:]
为了访问不越界，最好加成员变量保存数组的大小
[/Quote]
可否详解？

[lee1800]

[Quote=引用 2 楼 oldn_cc_bird 的回复:]
如果GetAllMatchData被多次调用会有内存泄露.
构造函数中
m_ClrItems = NULL;
m_Timeindex= NULL;
改成
C/C++ codeif(m_Timeindex)
{
delete [] m_Timeindex;
}
m_Timeindex=newint [CountofItems];
if(m_ClrItems)
{
delete [] m_ClrItems;
}
m_ClrItems=new ClrStruct [CountofItems];
[/Quote]

问题的关键就是这 countofItems 要在GetAllMatchData中才得知是大小是多少
但是GetAllMatchData并不是构造函数 请问要怎么处理才好呢？

[lee1800]

大家帮忙看下 谢谢！

[oldn123]

CPaintTable::CPaintTable(void)
{
    m_Timei = 0;
    m_NewResulti = 0;
    m_LiveD.Rst =0;
    m_LiveD.Data.RemoveAll();
    m_LiveD.fn = 0;

    m_ClrItems = NULL; 
    m_Timeindex= NULL; 

}
/*---------------------------------------------------------------------------
* 函数名称：~CPaintTable(void);

* 函数功能：析构函数
----------------------------------------------------------------------------*/
CPaintTable::~CPaintTable(void)
{
if(m_Timeindex)
    delete []m_Timeindex;
if(ClrItems)
    delete []m_ClrItems;
}


void CPaintTable::GetAllMatchData(CWnd *pwnd,CStringArray &XMLI,int &ViewW,int &ViewH)
{
    int NewResultTemp = 0;
    m_XMLItems.Copy(XMLI);
    //m_GXML.GetMatchState(m_XMLItems,m_MatchState);
    m_GXML.DateNumber(m_XMLItems,m_DateItems);
    //按日期排位置
    m_GXML.CompositorFunction(m_XMLItems,0,m_XMLItems.GetSize()-1,TimeCompositor);
    m_GXML.DataProcessing(m_DateItems,m_XMLItems);//,m_MatchNow);
    long CountofItems = 0;
    CountofItems = m_XMLItems.GetSize();
        //重点在这。。
    if(m_Timeindex)
   {
      delete [] m_Timeindex;
   }
   m_Timeindex = new int [CountofItems];

   if(m_ClrItems)
   {
     delete [] m_ClrItems;
   }
m_ClrItems = new ClrStruct [CountofItems];
    for( int i = 0; i < CountofItems; i++ )
    {
        if (m_XMLItems.GetAt(i) != _T("$$"))
        {
            m_ClrItems[i] = m_GXML.ParseXMLClr(m_XMLItems.GetAt(i));
        }
        if (m_XMLItems.GetAt(i) == _T("%%"))
        {
            NewResultTemp++;
        }
    }

    CClientDC dc (pwnd);
    m_nCellWidth = dc.GetDeviceCaps (LOGPIXELSX);
    m_nCellHeight = dc.GetDeviceCaps (LOGPIXELSY) / 4 - 10;
    ViewW = nViewWidth;
    ViewH = m_nCellHeight * ((CountofItems)*2 - m_DateItems.GetSize() - NewResultTemp );
}