JavaSrcipt语句正确吗？急·····

[猪猪飞侠]

我想通href方法实现一个表单的提交，然后在转入超链接，执行的时候总是显示网页错误，请问一下javaScript哪里出了问题
function href(){
function sub(){
window.document.getElementById("formId").submit();
}
var goodsid=document.getElementById("goodid").value;
var goodsname=document.getElementById("goodsname").value;
var goodsprice=document.getElementById("goodsprice").value;
document.location.href=cart.action?goodsmessage.goodsId=goodid&goodsmessage.goodsname=goodsname&goodsmessage.goodsprice=goodprice;
}

[chjpeng]

1.定义的变量与使用的变量不一致
2.字符串与变量不应混用

var goodsid=document.getElementById("goodid").value;
var goodsname=document.getElementById("goodsname").value;
var goodsprice=document.getElementById("goodsprice").value;
document.location.href='cart.action?goodsmessage.goodsId='+goodsid+'&goodsmessage.goodsname='+goodsname+'&goodsmessage.goodsprice='+goodsprice;