高手，我需要真正的高手来···

[derek1321]

做了个项目，但是在录入操作记录的时候页面执行页面变很慢，去掉log.cs这个文件速度就正常了。
求高手来帮忙看看，是不是程序出了问题~~ 如下 ：
public class log : System.Web.UI.Page
{
public void logEdit(string cz)
{

string pcName = Dns.GetHostName();
IPHostEntry myEntry = Dns.GetHostEntry(Dns.GetHostName());
string ip1 = myEntry.AddressList[0].ToString();
string operater = Session["userName"].ToString() + HttpContext.Current.Request.UserHostAddress;
string createDate = System.DateTime.Now.ToShortDateString();
string lognew = Session["department"].ToString() + Session["userName"].ToString();
string sql = "insert into log VALUES( '" + lognew + "','" + cz + "','" + ip1 + "','" + operater + "','" + createDate + "','" + pcName + "')";
Maticsoft.DBUtility.DbHelperSQL.ExecuteSql(sql);


}
}
}

[q107770540]

string sql = "insert into log （具体字段） VALUES( '" + lognew + "','" + cz + "','" + ip1 + "','" + operater + "','" + createDate + "','" + pcName + "')";

注意字段类型

参数化SQL

[鸭梨山大帝]

1.IPHostEntry myEntry = Dns.GetHostEntry(Dns.GetHostName()); 不需要每次都去取,缓存下来.

2."insert into log " 每一次Log都执行一次Insert,如果log表过大且索引没建好,肯定影响效能.
推荐先缓存结果,然后批次插入.提升效能相当的明显的.

[damjmk2]

可以检测一下每条语句执行了多长时间,然后才好判断哪里耗时了

[derek1321]

杂缓存下来哦~楼上的~ 麻烦教一下咧~ 谢谢~~~~

[cactus123456]

你按照我改的再试试
public class log : System.Web.UI.Page
{
public void logEdit(string cz)
{

string pcName = "";
//IPHostEntry myEntry = Dns.GetHostEntry(Dns.GetHostName());
string ip1 = "";
string operater = Session["userName"].ToString() + HttpContext.Current.Request.UserHostAddress;
string createDate = System.DateTime.Now.ToShortDateString();
string lognew = Session["department"].ToString() + Session["userName"].ToString();
string sql = "insert into log VALUES( '" + lognew + "','" + cz + "','" + ip1 + "','" + operater + "','" + createDate + "','" + pcName + "')";
Maticsoft.DBUtility.DbHelperSQL.ExecuteSql(sql);


}
}
}

[liuqilin1987]

[Quote=引用 1 楼 q107770540 的回复:]
string sql = "insert into log （具体字段） VALUES( '" + lognew + "','" + cz + "','" + ip1 + "','" + operater + "','" + createDate + "','" + pcName + "')";

注意字段类型

参数化SQL
[/Quote]
倾向于1楼观点，这样可以提高效率