请教一下!代码冗余,觉得应该用泛型或接口解决,但不知道具体怎么办好

lqh3417 2010-10-25 08:45:23

Method1(),Method2(),Method3()唯一不同的是生成类的类名,算法都一样。我想把它们变为Method<T>(){...}调用时Method<Class1>(),Method<Class2>(),Method<Class3>()但是没办法调用T的方法out()和实例化它。我想请问一下应该如何优化这段代码?


using System;
using System.Collections.Generic;
using System.Text;

namespace ConsoleApplication1
{
class Class0
{
static void Main()
{
Class0 c1 = new Class0();
string s=Console.ReadLine();
while (s!= "0")
{
switch(s)
{
case "1": c1.Method1(); break;
case "2": c1.Method2(); break;
case "3": c1.Method3(); break;
default: break;
}
s = Console.ReadLine();
}

}
public void Method1()
{
for (int i = 1; i < 5; i++)
{
Class1 cc = new Class1(i, 2*i,3*i);
cc.Out();
}
}

public void Method2()
{
for (int i = 1; i < 5; i++)
{
Class2 cc = new Class2(i, 2 * i, 3 * i);
cc.Out();
}
}

public void Method3()
{
for (int i = 1; i < 5; i++)
{
Class3 cc = new Class3(i, 2 * i, 3 * i);
cc.Out();
}
}

}
public class Class1
{
int a, b, c;
public Class1(int a,int b,int c)
{
this.a = a;
this.b = b;
this.c = c;
}

public void Out()
{
Console.WriteLine("class1:I got {0},{1},{2}", a, b, c);
Console.WriteLine("class1:1st one is {0}" , a);
}
}
public class Class2
{
int a, b, c;

public Class2(int a,int b,int c)
{
this.a = a;
this.b = b;
this.c = c;
}

public void Out()
{
Console.WriteLine("class2:I got {0},{1},{2}", a, b, c);
Console.WriteLine("class2:2nd one is {0}",b);
}
}
public class Class3
{
int a, b, c;
public Class3(int a,int b,int c)
{
this.a = a;
this.b = b;
this.c = c;
}

public void Out()
{
Console.WriteLine("class3:I got {0},{1},{2}",a,b,c);
Console.WriteLine("class3:3rd one is {0}" , c);
}
}
}
...全文
197 9 打赏 收藏 转发到动态 举报
写回复
用AI写文章
9 条回复
切换为时间正序
请发表友善的回复…
发表回复
lqh3417 2010-10-26
  • 打赏
  • 举报
回复
在学校比较早睡,不好意思,看来大家都比较晚的哦呵呵。
嗯嗯,后来的方法都很不错很具体,开始学习了!实在不懂再指教一下吧~~
skyering 2010-10-26
  • 打赏
  • 举报
回复

public interface IOut
{
void Init(int a, int b, int c);
void Out();
}

public void Method<T>() where T : IOut, new()
{
for (int i = 1; i < 5; i++)
{
T cc = new T();
cc.Init(i, 2 * i, 3 * i);
cc.Out();
}
}

就像六楼的代码所示,运用泛型约束技术。接口IOut实现泛型参数需要调用的接口。
兔子-顾问 2010-10-25
  • 打赏
  • 举报
回复
如果用继承+反射
using System;
using System.Collections.Generic;
using System.Text;

namespace ConsoleApplication1
{
class Class0
{
static void Main()
{
Class0 c1 = new Class0();
string s = Console.ReadLine();
while (s != "0")
{
switch (s)
{
case "1": c1.Method<Class1>(); break;
case "2": c1.Method<Class2>(); break;
case "3": c1.Method<Class3>(); break;
default: break;
}
s = Console.ReadLine();
}

}

public void Method<T>() where T : ClassBase
{
for (int i = 1; i < 5; i++)
{
T cc = (T)Activator.CreateInstance(typeof(T), i, 2 * i, 3 * i);
cc.Out();
}
}
}
public abstract class ClassBase
{
public int a, b, c;
public ClassBase(int a, int b, int c)
{
this.a = a;
this.b = b;
this.c = c;
}
public abstract void Out();
}

public class Class1 : ClassBase
{
public Class1(int a, int b, int c)
: base(a, b, c)
{
}
public override void Out()
{
Console.WriteLine("class1:I got {0},{1},{2}", a, b, c);
Console.WriteLine("class1:1st one is {0}", a);
}
}
public class Class2 : ClassBase
{
public Class2(int a, int b, int c)
: base(a, b, c)
{
}
public override void Out()
{
Console.WriteLine("class2:I got {0},{1},{2}", a, b, c);
Console.WriteLine("class2:1st one is {0}", a);
}
}
public class Class3 : ClassBase
{
public Class3(int a, int b, int c)
: base(a, b, c)
{
}
public override void Out()
{
Console.WriteLine("class3:I got {0},{1},{2}", a, b, c);
Console.WriteLine("class3:1st one is {0}", a);
}
}
}
兔子-顾问 2010-10-25
  • 打赏
  • 举报
回复
可以定义接口。然后这样写
using System;
using System.Collections.Generic;
using System.Text;

namespace ConsoleApplication1
{
public interface IOut
{
void Init(int a, int b, int c);
void Out();
}
class Class0
{
static void Main()
{
Class0 c1 = new Class0();
string s = Console.ReadLine();
while (s != "0")
{
switch (s)
{
case "1": c1.Method1(); break;
case "2": c1.Method2(); break;
case "3": c1.Method3(); break;
default: break;
}
s = Console.ReadLine();
}

}

public void Method<T>() where T : IOut, new()
{
for (int i = 1; i < 5; i++)
{
T cc = new T();
cc.Init(i, 2 * i, 3 * i);
cc.Out();
}
}

public void Method1()
{
for (int i = 1; i < 5; i++)
{
Class1 cc = new Class1(i, 2 * i, 3 * i);
cc.Out();
}
}

public void Method2()
{
for (int i = 1; i < 5; i++)
{
Class2 cc = new Class2(i, 2 * i, 3 * i);
cc.Out();
}
}

public void Method3()
{
for (int i = 1; i < 5; i++)
{
Class3 cc = new Class3(i, 2 * i, 3 * i);
cc.Out();
}
}

}
public class Class1 : IOut
{
int a, b, c;
public Class1() { }
public Class1(int a, int b, int c)
{
this.a = a;
this.b = b;
this.c = c;
}


public void Init(int a, int b, int c)
{
this.a = a;
this.b = b;
this.c = c;
}

public void Out()
{
Console.WriteLine("class1:I got {0},{1},{2}", a, b, c);
Console.WriteLine("class1:1st one is {0}", a);
}
}
public class Class2 : IOut
{
int a, b, c;
public Class2() { }
public Class2(int a, int b, int c)
{
this.a = a;
this.b = b;
this.c = c;
}

public void Init(int a, int b, int c)
{
this.a = a;
this.b = b;
this.c = c;
}

public void Out()
{
Console.WriteLine("class2:I got {0},{1},{2}", a, b, c);
Console.WriteLine("class2:2nd one is {0}", b);
}
}
public class Class3 : IOut
{
int a, b, c;
public Class3() { }
public Class3(int a, int b, int c)
{
this.a = a;
this.b = b;
this.c = c;
}

public void Init(int a, int b, int c)
{
this.a = a;
this.b = b;
this.c = c;
}

public void Out()
{
Console.WriteLine("class3:I got {0},{1},{2}", a, b, c);
Console.WriteLine("class3:3rd one is {0}", c);
}
}
}
lqh3417 2010-10-25
  • 打赏
  • 举报
回复
代码最好编译通过再贴出来啊,比如yangglemu的代码错误就是t使用了未赋值的变量,还有Class1,Class2,Class3构造函数要有参数的,要通过算法循环代入参数并调用其out方法

而且请wuyq11讲明白一些吧,要代码说明而不只是文字描述
lqh3417 2010-10-25
  • 打赏
  • 举报
回复
说到派生,我想用接口也行吧?如果可以,应该怎么用呢?
还有用泛型行吗?好像这种特性很少被用到呃,是不是不适合于解决这个问题啊?
  • 打赏
  • 举报
回复
弄一个基类:
public class Test
{
int a, b, c;

public Test(int a,int b,int c)
{
this.a = a;
this.b = b;
this.c = c;
}

public virtual void Out()
{

}
}

在派生出三个类,只要重写Out方法即可

Main方法中:
Test t;
switch(s)
{
case "1": t=new Class1(); break;
case "2": t=new Class2(); break;
case "3": t=new Class3(); break;
default: break;
}
if(t!=null)
t.Out();

lqh3417 2010-10-25
  • 打赏
  • 举报
回复
啊!!!这样也行????不过您的意思我还不太明白,是T.GetType吗?
wuyq11 2010-10-25
  • 打赏
  • 举报
回复
public void Method1<T>(T t)
{
判断类型Type t = typeof(T);

}

111,129

社区成员

发帖
与我相关
我的任务
社区描述
.NET技术 C#
社区管理员
  • C#
  • Creator Browser
  • by_封爱
加入社区
  • 近7日
  • 近30日
  • 至今
社区公告

让您成为最强悍的C#开发者

试试用AI创作助手写篇文章吧