之前他们给发了一个笔试题,我把代码写好以后就发给他们了。今天主要是对我的代码现场进行重构。他们之所以如此的喜欢重构,大概跟《重构》的作者Martin Fowler就在这家公司有关系吧。
我的代码有这么一个方法:
public void setPoint(Point point){
int x = point.getX();
int y = point.getY();
int new_x = x;
int new_y = y;
if(x<LOWER_LEFT_POINT.getX()){
new_x = LOWER_LEFT_POINT.getX();
}
if(x > UPPER_RIGHT_POINT.getX()){
new_x = UPPER_RIGHT_POINT.getX();
}
if(y < LOWER_LEFT_POINT.getY()){
new_y = LOWER_LEFT_POINT.getY();
}
if(y > UPPER_RIGHT_POINT.getY()){
new_y = UPPER_RIGHT_POINT.getY();
}
this.point = new Point(new_x,new_y);
}
他们就说,有没有看出来你的代码里面存在重复代码?我是楞没看出来。然后,他就手动抽出来一个方法,就在这个时候连IDE都提示说有重复代码了,可我还是没看出来!逗得那两个GG笑得很开心。然后我就越心虚。最后,他从这段代码抽出两个方法,然后改了改方法里的局部变量名,这时候我才发现,这两个函数是一模一样的,汗死了!再往后,很多已经不再是某个小细节的问题了。
那个GG对我的评价是,基本上不具备的面向对象的设计和分析能力。虽然这么说有点伤感情,但是心服口服,本来以为自己对面向对象还算了解吧,看来还有很长一段路要走啊!
把原题发给大家看看:
MARS ROVERS
A squad of robotic rovers are to be landed by NASA on a plateau on Mars. This plateau, which is curiously rectangular, must be navigated by the rovers so that their on-board cameras can get a complete view of the surrounding terrain to send back to Earth.
A rover's position and location is represented by a combination of x and y co-ordinates and a letter representing one of the four cardinal compass points. The plateau is divided up into a grid to simplify navigation. An example position might be 0, 0, N, which means the rover is in the bottom left corner and facing North.
In order to control a rover, NASA sends a simple string of letters. The possible letters are 'L', 'R' and 'M'. 'L' and 'R' makes the rover spin 90 degrees left or right respectively, without moving from its current spot. 'M' means move forward one grid point, and maintain the same heading.
Assume that the square directly North from (x, y) is (x, y+1).
INPUT:
The first line of input is the upper-right coordinates of the plateau, the lower-left coordinates are assumed to be 0,0.
The rest of the input is information pertaining to the rovers that have been deployed. Each rover has two lines of input. The first line gives the rover's position, and the second line is a series of instructions telling the rover how to explore the plateau.
The position is made up of two integers and a letter separated by spaces, corresponding to the x and y co-ordinates and the rover's orientation.
Each rover will be finished sequentially, which means that the second rover won't start to move until the first one has finished moving.
OUTPUT
The output for each rover should be its final co-ordinates and heading.
INPUT AND OUTPUT
Test Input:
5 5
1 2 N
LMLMLMLMM
3 3 E
MMRMMRMRRM
Expected Output:
1 3 N
5 1 E