下面代码怎么封装？

[mohaixueyuan]

我的代码里面有很多

//省略代码
char szName[128] = {0};
for (int i=0; i<32; i++)
{
   sprintf(szName, "Flash01_%02d.png", i+1);
   //省略代码
}
//省略代码

里面除了sprintf产生的szName不一样，其他的完全一样。请教大牛们，这该怎么封装？

[DBG-CHEN]

帮你顶,不知道。

[mohaixueyuan]

想过这样封装

int* DTools::createSip(float delayPerUnit, const char* fmt, ...)
{
	//省略代码
	char szName[128] = {0};
 	for ( int i = 0; i < 32; i++ )
 	{
		va_list arg;
		va_start(arg, fmt);
		vsprintf(szName, fmt, arg);

		//省略代码
 	}

	//省略代码
}

但是调用的时候int*pResult = DTools::createSip(0.015f, "Flash01_%02d.png", i+1); 这时候还没有i。。。

[billzheng]

write a function to generate a vector of file names

std::vector<std::string> generateFileNames()
{ 
    std::string prefix("Flash01_"); 
    std::string ext("d.png");

    std::vector<std::string> files;

    for (int i=0; i<32; ++i)
    {
      std::string fn(prefix);
      fn += std::to_string(i);
      fn += ext;
      files.push_back(fn);
    }
    return files;
}

Then you operate on the vector if you need to: std::vector<std::string> files = generateFileNames(); for (std::vector<std::string>::iterator it = files.begin(); it != files.end(); ++it) { // do something. }

[mohaixueyuan]

引用 3 楼 billzheng 的回复:

write a function to generate a vector of file names

std::vector<std::string> generateFileNames()
{ 
    std::string prefix("Flash01_"); 
    std::string ext("d.png");

    std::vector<std::string> files;

    for (int i=0; i<32; ++i)
    {
      std::string fn(prefix);
      fn += std::to_string(i);
      fn += ext;
      files.push_back(fn);
    }
    return files;
}

Then you operate on the vector if you need to: std::vector<std::string> files = generateFileNames(); for (std::vector<std::string>::iterator it = files.begin(); it != files.end(); ++it) { // do something. }

感谢billzheng的回答，你的这个想法我也考虑过，就是不知道有没更好的实现

[billzheng]

引用 4 楼 mohaixueyuan 的回复:

[quote=引用 3 楼 billzheng 的回复:] write a function to generate a vector of file names

std::vector<std::string> generateFileNames()
{ 
    std::string prefix("Flash01_"); 
    std::string ext("d.png");

    std::vector<std::string> files;

    for (int i=0; i<32; ++i)
    {
      std::string fn(prefix);
      fn += std::to_string(i);
      fn += ext;
      files.push_back(fn);
    }
    return files;
}

Then you operate on the vector if you need to: std::vector<std::string> files = generateFileNames(); for (std::vector<std::string>::iterator it = files.begin(); it != files.end(); ++it) { // do something. }

感谢billzheng的回答，你的这个想法我也考虑过，就是不知道有没更好的实现[/quote] The discipline of design is to make one function do one thing, make a class do one thing.