敬请帮忙，来者有分!!

[Thumb168]

小弟初学，请大家看看我写的这个类有没有问题,因怕内存出现问题，所以．．．　
Public Class NewsPop
Implements IDisposable

Private m_sqlconnect As System.Data.SqlClient.SqlConnection
Private m_sqlcommand As SqlClient.SqlCommand
Private disposed As Boolean = False


Public Function GetNewsData() As SqlClient.SqlDataReader
m_sqlconnect.ConnectionString = "workstation id=HOME501;packet size=4096;user id=webuser;data source=localhost;persist security info=True;initial catalog=web;password=501"
m_sqlcommand.CommandType = CommandType.Text
m_sqlcommand.CommandText = "select top 5 newsname,[top],[left],[width],[height] from newspop"
m_sqlconnect.Open()
m_sqlcommand.Connection = m_sqlconnect
Return m_sqlcommand.ExecuteReader
End Function

Protected Overrides Sub Finalize()
Dispose(False)
MyBase.Finalize()
End Sub

Public Sub New()
m_sqlconnect = New SqlClient.SqlConnection
m_sqlcommand = New SqlClient.SqlCommand
End Sub

Public Overloads Sub Dispose() Implements System.IDisposable.Dispose
Dispose(True)
GC.SuppressFinalize(Me)

End Sub
Protected Overloads Sub Dispose(ByVal disposing As Boolean)
If Not Me.disposed Then
If disposing Then
' Dispose managed resources.
m_sqlconnect.Dispose()
End If
End If
If Not Me.disposed Then
If disposing Then
' Dispose managed resources.
m_sqlcommand.Dispose()
End If
End If
End Sub

End Class

[bitsbird]

m_sqlconnect.Open()
m_sqlcommand.Connection = m_sqlconnect
----------------------------
m_sqlcommand.Connection = m_sqlconnect
m_sqlconnect.Open()

[zedan]

vb啊，帮你顶一下吧

[Night_Elf]

bitsbird(一瓢.net) 说的没错！

[小笨和漂向北方]

你实现了丢弃模式，实现IDisposable
但你没有实现析构函数啊？要GC.SuppressFinalize(Me)没有意义，只有既实现了丢弃模式又有析构函数的情况下，才会在dispose中要求GC不要再次调用析构函数清理资源。

[goody9807]

public void Dispose() {
// make sure connection is closed
if (con != null) {
con.Dispose();
con = null;
}
}