谁能调试通如下代码,100分相送,我调式总是出问题

[Javpp]

在for (aNode = TreeView->Items->GetFirstNode (); aNode != NULL ;)里出问题,ndata = (NODEDATA*) (aNode->Data);这一句,

代码如下:数据表里就3个字段,一个ID,一个父ID:PID,一个是名字,根据这些初始化一棵树,一看就明白,忘记从哪里看到的这段代码了


void __fastcall TfrmMain::FillTree ()
{
struct NODEDATA *ndata = NULL;
TStringList *ss = NULL;

TTreeNode *aNode = NULL;
TTreeNode *bNode = NULL;
TTreeNode *pNode = NULL;

ADOQuery1->Close ();
ADOQuery1->SQL->Clear ();
ADOQuery1->SQL->Add ("SELECT ID, PID, Name FROM Infor");
ADOQuery1->Open ();

try
{
ss = new TStringList ();
TreeView->Items->BeginUpdate ();
ndata = new NODEDATA ();
ADOQuery1->First ();
while (!ADOQuery1->Eof)
{
ndata->id = ADOQuery1->FieldByName ("id")->AsInteger;
ndata->pid = ADOQuery1->FieldByName ("id")->AsInteger;
ndata->name = ADOQuery1->FieldByName ("name")->AsString;

aNode = TreeView->Items->AddObject (NULL, ndata->name, ndata);

ss->AddObject (AnsiString (ndata->id), aNode);
ADOQuery1->Next ();
}
ADOQuery1->Close ();
ndata = NULL;

int idx;
for (aNode = TreeView->Items->GetFirstNode (); aNode != NULL ;)
{
ndata = (NODEDATA*) (aNode->Data);
if (-1 == (idx = ss->IndexOf (AnsiString (ndata->pid))))
{
aNode = aNode->getNextSibling ();
continue;
}
else
{
pNode = (TTreeNode*)(ss->Objects[idx]);
bNode = aNode;
aNode = aNode->getNextSibling();
bNode->MoveTo (pNode, naAddChild);
}
}
//delete ndata;
}
__finally
{
delete ss;
ss = NULL;
delete ndata;
ndata = NULL;
ADOQuery1->Close ();
TreeView->Items->EndUpdate ();
}
}

[geochway]

语法没问题,感觉还是TTreeView的方法调用不对吧.

[Javpp]

运行没问题，但是结果不对，

[samchoy]

如果你这段程序是直接复制过来的，那可能是这里错了：

void __fastcall TfrmMain::FillTree ()
{
struct NODEDATA *ndata = NULL;
TStringList *ss = NULL;

TTreeNode *aNode = NULL;
TTreeNode *bNode = NULL;
TTreeNode *pNode = NULL;

ADOQuery1->Close ();
ADOQuery1->SQL->Clear ();
ADOQuery1->SQL->Add ("SELECT ID, PID, Name FROM Infor");
ADOQuery1->Open ();

try
{
ss = new TStringList ();
TreeView->Items->BeginUpdate ();
ndata = new NODEDATA ();
ADOQuery1->First ();
while (!ADOQuery1->Eof)
{
ndata->id = ADOQuery1->FieldByName ("id")->AsInteger;

/////////////////////////////////////////////////////////////////////////
// 这里错了，应该是 ndata->pid = ADOQuery1->FieldByName ("pid")->AsInteger;
ndata->pid = ADOQuery1->FieldByName ("id")->AsInteger;
/////////////////////////////////////////////////////////////////////////

ndata->name = ADOQuery1->FieldByName ("name")->AsString;

aNode = TreeView->Items->AddObject (NULL, ndata->name, ndata);

ss->AddObject (AnsiString (ndata->id), aNode);
ADOQuery1->Next ();
}
ADOQuery1->Close ();
ndata = NULL;

int idx;
for (aNode = TreeView->Items->GetFirstNode (); aNode != NULL ;)
{
ndata = (NODEDATA*) (aNode->Data);
if (-1 == (idx = ss->IndexOf (AnsiString (ndata->pid))))
{
aNode = aNode->getNextSibling ();
continue;
}
else
{
pNode = (TTreeNode*)(ss->Objects[idx]);
bNode = aNode;
aNode = aNode->getNextSibling();
bNode->MoveTo (pNode, naAddChild);
}
}
//delete ndata;
}
__finally
{
delete ss;
ss = NULL;
delete ndata;
ndata = NULL;
ADOQuery1->Close ();
TreeView->Items->EndUpdate ();
}
}

[Javpp]

不是，首先
aNode = TreeView->Items->AddObject (NULL, ndata->name, ndata);

但是在ndata = (NODEDATA*) (aNode->Data);
的时候并不能得到，除了TREEVIEW中最后一个可以，别的都是NULL

[Javpp]

我是COPY来的，但不是原来的，我也改过了

[samchoy]

对了，还要把 ndata = new NODEDATA ();
放在 while (!ADOQuery1->Eof) 循环中，要不然只是对同一个地址不断赋值

[samchoy]

改成这样试试

void __fastcall TfrmMain::FillTree ()
{
struct NODEDATA *ndata = NULL;
TStringList *ss = NULL;

TTreeNode *aNode = NULL;
TTreeNode *bNode = NULL;
TTreeNode *pNode = NULL;

ADOQuery1->Close ();
ADOQuery1->SQL->Clear ();
ADOQuery1->SQL->Add ("SELECT ID, PID, Name FROM Infor");
ADOQuery1->Open ();

try
{
ss = new TStringList ();
TreeView->Items->BeginUpdate ();
ADOQuery1->First ();
while (!ADOQuery1->Eof)
{
ndata = new NODEDATA ();
ndata->id = ADOQuery1->FieldByName ("id")->AsInteger;
ndata->pid = ADOQuery1->FieldByName ("pid")->AsInteger; // 这里取的应该是pid
ndata->name = ADOQuery1->FieldByName ("name")->AsString;

aNode = TreeView->Items->AddObject (NULL, ndata->name, ndata);

ss->AddObject (AnsiString (ndata->id), aNode);
ADOQuery1->Next ();
}
ADOQuery1->Close ();
ndata = NULL;

int idx;
for (aNode = TreeView->Items->GetFirstNode (); aNode != NULL ;)
{
ndata = (NODEDATA*) (aNode->Data);
if (-1 == (idx = ss->IndexOf (AnsiString (ndata->pid))))
{
aNode = aNode->getNextSibling ();
continue;
}
else
{
pNode = (TTreeNode*)(ss->Objects[idx]);
bNode = aNode;
aNode = aNode->getNextSibling();
bNode->MoveTo (pNode, naAddChild);
}
}
//delete ndata;
}
__finally
{
delete ss;
ss = NULL;
delete ndata; // 这里要改用循环释放各个TreeNode的Data
ndata = NULL;
ADOQuery1->Close ();
TreeView->Items->EndUpdate ();
}
}